Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove contest editorial column if empty #1406

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

kevinjycui
Copy link
Contributor

Removes editorial column on a finished contest if there are no public editorials.
To replicate original bug:

  • Find or create a contest with only problems that have no public editorials
  • Open contest page and look at "Problems" table

    Note the empty column at the end of the table, where editorials would be if public editorials existed
    Fix:
    image

@kevinjycui kevinjycui force-pushed the editorial-column-bug branch from 794465c to 0100326 Compare May 31, 2020 23:52
@kevinjycui kevinjycui force-pushed the editorial-column-bug branch 2 times, most recently from e8e35f0 to 21a288f Compare June 1, 2020 00:10
@kevinjycui kevinjycui force-pushed the editorial-column-bug branch from 21a288f to ce527de Compare June 1, 2020 00:16
Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xyene Xyene merged commit 06aaa68 into DMOJ:master Jun 1, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants